View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000056 | NewsStats | Reports | public | 2018-01-01 21:28 | 2018-01-01 21:56 |
Reporter | thh | Assigned To | thh | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Projection | none | ETA | none | ||
Product Version | 0.01 | Product Build | |||
Target Version | 0.02 | Fixed in Version | 0.02 | ||
Summary | 0000056: Upper/lower boundary of 0 is ignored | ||||
Description | If you call groupstats.pl with an upper (or lower) boundary of 0 (zero), the boundary condition is ignored. | ||||
Steps To Reproduce | $ groupstats.pl -m 2015-01:2017-12 -r avg -b level -u 0 -o postings-desc This report should include all groups that have no (0, zero) postings for the whole time (of three years). In fact, it inlcudes all groups. The boundary condition "--upper 0" is ignored, | ||||
Additional Information | This bug is due to the code checking for upper or lower boundary being TRUE instead of defined(). A boundary of "0" is understood as "no boundary set". | ||||
Tags | No tags attached. | ||||
NewsStats: next b5ef5726 2018-01-01 21:29:00 Thomas Hochstein Details Diff |
Accept an upper/lower boundary of 0 (zero). The code checks if a boundary is set by looking for a TRUE value, but 0 is FALSE. It has to check whether the variable is set, i.e. defined(), instead. Fixes 0000056. Signed-off-by: Thomas Hochstein <thh@inter.net> |
Affected Issues 0000056 |
|
mod - lib/NewsStats.pm | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-01-01 21:28 | thh | New Issue | |
2018-01-01 21:28 | thh | Status | new => assigned |
2018-01-01 21:28 | thh | Assigned To | => thh |
2018-01-01 21:55 | thh | Changeset attached | => NewsStats next b5ef5726 |
2018-01-01 21:56 | thh | Status | assigned => resolved |
2018-01-01 21:56 | thh | Resolution | open => fixed |
2018-01-01 21:56 | thh | Fixed in Version | => 0.02 |
2018-01-01 21:56 | thh | Note Added: 0000091 |