View Issue Details

IDProjectCategoryView StatusLast Update
0000012NewsStats[All Projects] Generalpublic2013-09-02 12:56
ReporterthhAssigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status acknowledgedResolutionopen 
ProjectionnoneETAnone 
Product VersionProduct Build 
Target VersionFixed in Version 
Summary0000012: Enhance input validation and error handling.
DescriptionAll external input should be validated, all possible error conditions should be handled. That's not yet completely implemented.
TagsNo tags attached.

Relationships

parent of 0000013 resolvedthh Input validation / error handling for configuration files 
parent of 0000030 resolvedthh feedlog.pl will loose database connection permanently when interrupted 

Activities

There are no notes attached to this issue.

Related Changesets

NewsStats: next edd250f2

2012-05-02 16:11:43

thh

Details Diff
Complete rewrite of groupstats.pl and NewsStats.pm.

* Switch to Getopt::Long, change coding style;
limit line length.

* Replace 'die' and 'warn' by calls to &Bleat().

* Completely redo options and processing:
- merge -m/-p/-a into --month
- replace -i/-q/-d with - much more powerful -
--group-by/--order-by
- replace -t/-l with - much more powerful -
--lower/--upper/--boundary
- remove -b and replace it with --report

Fixes 0000033.

* Add new report types, boundaries and sorting options:
- report types 'average' and 'sums'
- boundaries 'average' and 'sums'
- upper and/or lower boundary
- sort output independently

Issue 0000035.
Fixes 0000034, 0000038.

* Add possibility to cross-check newsgroups against
checkgroups file.

* Complete rewrite of groupstats.pl internal logic:
- modularize construction fo SQL queries
- remove unnecessary special cases
- refactor code into NewsStats.pm functions as much
as possible

Issue 0000037.
Fixes 0000036.

* Rework output formats, fix padding problem by making use
of modularized SQL queries.

Fixes 0000015, 0000032.

* Add some more consistency checks.

Issue 0000012.

* Redo documentation.

* Update TODO list.

Signed-off-by: Thomas Hochstein <thh@inter.net>
mod - groupstats.pl Diff File
mod - NewsStats.pm Diff File
mod - doc/TODO Diff File

NewsStats: next c30822b4

2013-09-02 06:51:45

thh

Details Diff
Check for invalid newsgroup names.

Add check to SQLGroupList() and act on it
in groupstats.pl.

Issue 0000012.

Signed-off-by: Thomas Hochstein <thh@inter.net>
mod - groupstats.pl Diff File
mod - NewsStats.pm Diff File

Issue History

Date Modified Username Field Change
2010-09-19 17:02 thh New Issue
2010-09-19 17:59 thh Relationship added parent of 0000013
2010-09-19 18:00 thh Status new => acknowledged
2011-01-19 22:54 thh Relationship added parent of 0000030
2013-09-02 06:58 thh Changeset attached => NewsStats next edd250f2
2013-09-02 12:56 thh Changeset attached => NewsStats next c30822b4